Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically retrieve external guids from libraries using includeGuids #831

Merged
merged 7 commits into from
Oct 4, 2021

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Sep 15, 2021

Description

Adds the includeGuids parameter added in Plex Media Server 1.24.3.5033. For older versions of PMS, accessing guids for a PlexPartialObject will still automatically reload the object.

https://forums.plex.tv/t/plex-media-server/30447/462

By default, external guids are automatically retrieved when using LibrarySection.all(), LibrarySection.search(), or LibrarySection.get(). Optionally, the external guids can also be skipped by adding the parameter includeGuids=False for all() or search() only.

Fixes #808


Adds new LibrarySection.getGuid(guid) method to return and item by external guid.

Closes #557


Note: The test is failing because includeGuids is not on the public PMS release yet. PMS 1.24.3.5033 has been publicly released.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit a3178f3 into pkkid:master Oct 4, 2021
@JonnyWong16 JonnyWong16 deleted the feature/includeGuids branch October 4, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-load guids for sections.all() Adding IMDb/TMDb search filter for the new plex movie agent
1 participant